Update Actionpack version to include all patches for 5.1#91
Update Actionpack version to include all patches for 5.1#91Jesterovskiy merged 2 commits intoroidrage:masterfrom
Conversation
|
@meatballhat Do I need fix RuboCop issues? Because he broken build. |
|
@Jesterovskiy FYI I've added a PR to fix the RuboCop issues #92 |
|
@Jesterovskiy The PR to fix RuboCop issues has been merged so hopefully if you rebase against master, this PR should be green 🤞 🙇 |
|
@jpawlyn Done! |
|
@roidrage your turn =) |
|
awesome, can this be merged and make a new release? |
|
I also need these changes in order to migrate a project to Rails 5.1 |
|
@jpawlyn can you check out this PR please? :) |
|
@nimashariatian I think we probably want one of the gem owners to take a look. They can hopefully merge the PR and release a new version. If you have a moment please... @meatballhat @dplummer @iancanderson 😃 |
|
oh thanks for the update @jpawlyn ! |
|
Bump! We need a new release of |
|
yes and then we can all party? lol |
|
seems it's not going to work, because i'm getting error: |
|
that's because this PR hasn't been merged yet @attenzione. you can point your gem to this PR like so: |
|
this PR will not fix issue with
|
|
oh you're right, was looking at the wrong PR |
|
Hey @Jesterovskiy thanks for getting this PR up and then merging it. Will a new release of them gem to Rubygems.org be coming soon? |
No description provided.