Skip to content

Update Actionpack version to include all patches for 5.1#91

Merged
Jesterovskiy merged 2 commits intoroidrage:masterfrom
Jesterovskiy:master
Aug 28, 2017
Merged

Update Actionpack version to include all patches for 5.1#91
Jesterovskiy merged 2 commits intoroidrage:masterfrom
Jesterovskiy:master

Conversation

@Jesterovskiy
Copy link
Collaborator

No description provided.

@Jesterovskiy
Copy link
Collaborator Author

@meatballhat Do I need fix RuboCop issues? Because he broken build.

@jpawlyn
Copy link
Contributor

jpawlyn commented May 30, 2017

@Jesterovskiy FYI I've added a PR to fix the RuboCop issues #92

@jpawlyn
Copy link
Contributor

jpawlyn commented Jun 24, 2017

@Jesterovskiy The PR to fix RuboCop issues has been merged so hopefully if you rebase against master, this PR should be green 🤞 🙇

@Jesterovskiy
Copy link
Collaborator Author

@jpawlyn Done!

@Jesterovskiy
Copy link
Collaborator Author

@roidrage your turn =)

@nimashariatian
Copy link

awesome, can this be merged and make a new release?

@nicubucalaete
Copy link

I also need these changes in order to migrate a project to Rails 5.1

@nimashariatian nimashariatian mentioned this pull request Aug 7, 2017
@nimashariatian
Copy link

@jpawlyn can you check out this PR please? :)

@jpawlyn
Copy link
Contributor

jpawlyn commented Aug 11, 2017

@nimashariatian I think we probably want one of the gem owners to take a look. They can hopefully merge the PR and release a new version. If you have a moment please... @meatballhat @dplummer @iancanderson 😃

@nimashariatian
Copy link

oh thanks for the update @jpawlyn !

@samcday
Copy link

samcday commented Aug 15, 2017

Bump! We need a new release of redis-session-store so we can move to Rails 5.1 please :)

@nimashariatian
Copy link

yes and then we can all party? lol

@attenzione
Copy link

seems it's not going to work, because i'm getting error:

Gem Load Error is: uninitialized constant Rack::Session::Abstract::ENV_SESSION_OPTIONS_KEY
Backtrace for gem load error is:
/lib/redis-session-store.rb:10:in `<class:RedisSessionStore>'

@nimashariatian
Copy link

that's because this PR hasn't been merged yet @attenzione. you can point your gem to this PR like so:
gem 'redis-session-store', git: "https://github.com/CapCap/redis-session-store"

@attenzione
Copy link

attenzione commented Aug 18, 2017

this PR will not fix issue with Rack::Session::Abstract::ENV_SESSION_OPTIONS_KEY, see "Files changed".

CapCap/redis-session-store is another fork with fix, but this PR is another

@nimashariatian
Copy link

oh you're right, was looking at the wrong PR

@Jesterovskiy Jesterovskiy merged commit bcf7792 into roidrage:master Aug 28, 2017
@samcday
Copy link

samcday commented Sep 2, 2017

Hey @Jesterovskiy thanks for getting this PR up and then merging it. Will a new release of them gem to Rubygems.org be coming soon?

@Jesterovskiy
Copy link
Collaborator Author

@samcday I don't have rights to release on rubygems. @roidrage can you help with this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants